Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring enhancement for providing fingrained erorr messages #41

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Bring enhancement for providing fingrained erorr messages #41

merged 8 commits into from
Jun 12, 2024

Conversation

CJHwong
Copy link
Member

@CJHwong CJHwong commented Jun 7, 2024 •
edited
Loading

Reason

Implement improvements to deliver more detailed error messages that can be easily understood.

Changes

  1. Drop support to Python 3.6
  2. Update pre-commit hooks
  3. Implement dsv_feature for specifying spec names
  4. Adjust the dsv decorator's behavior for Django requests

Test Scope

Checks

  • Unit tests are included or not applicable.

@CJHwong CJHwong requested review from xeonchen and mattwang44 June 7, 2024 04:48
mattwang44
mattwang44 reviewed Jun 7, 2024
View reviewed changes
setup.py Show resolved Hide resolved
test/test_nested_spec.py Show resolved Hide resolved
README.md Show resolved Hide resolved
@CJHwong CJHwong requested a review from mattwang44 June 7, 2024 07:18
mattwang44
mattwang44 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ongoing discussion should not block this PR

@CJHwong CJHwong merged commit fd20a7a into develop Jun 12, 2024
2 checks passed
@CJHwong CJHwong deleted the enhancement branch June 12, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwang44 mattwang44 mattwang44 approved these changes

@xeonchen xeonchen xeonchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CJHwong @xeonchen @mattwang44